FindBugs Bug Detector Report
The following document contains the results of FindBugs Report
FindBugs Version is 2.0.1
Threshold is low
Effort is max
Files
de.smartics.properties.api.config.domain.DuplicatePropertyException
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Format string should use %n rather than \n in de.smartics.properties.api.config.domain.DuplicatePropertyException.createMessage(Property, Property) | BAD_PRACTICE | VA_FORMAT_STRING_USES_NEWLINE | 82 | Medium |
de.smartics.properties.api.config.domain.key.ApplicationIdLoader
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of de.smartics.properties.api.config.domain.key.ApplicationIdLoader.cache which is known to be null in de.smartics.properties.api.config.domain.key.ApplicationIdLoader.getApplicatioIdFrom(URL) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE | 289 | Medium |
| de.smartics.properties.api.config.domain.key.ApplicationIdLoader.getApplicatioIdFrom(URL) does not release lock on all exception paths | MT_CORRECTNESS | UL_UNRELEASED_LOCK_EXCEPTION_PATH | 292 | Medium |
de.smartics.properties.impl.config.cache.CacheConfigurationPropertiesManagement
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class de.smartics.properties.impl.config.cache.CacheConfigurationPropertiesManagement implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 27-84 | Low |
de.smartics.properties.spi.config.ds.DefaultDataSourceManager
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| de.smartics.properties.spi.config.ds.DefaultDataSourceManager.dropConfigTable() may fail to clean up java.sql.Statement | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 437 | Medium |
| de.smartics.properties.spi.config.ds.DefaultDataSourceManager.print(PrintStream) may fail to clean up java.sql.ResultSet | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 473 | Medium |
| de.smartics.properties.spi.config.ds.DefaultDataSourceManager.print(PrintStream) may fail to clean up java.sql.Statement | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 468 | Medium |
| de.smartics.properties.spi.config.ds.DefaultDataSourceManager.initProperties(Connection) may fail to clean up java.sql.Statement on checked exception | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE | 399 | Medium |
| de.smartics.properties.spi.config.ds.DefaultDataSourceManager.dropConfigTable() may fail to close Statement | BAD_PRACTICE | ODR_OPEN_DATABASE_RESOURCE | 437 | Medium |
| de.smartics.properties.spi.config.ds.DefaultDataSourceManager.print(PrintStream) may fail to close Statement | BAD_PRACTICE | ODR_OPEN_DATABASE_RESOURCE | 468 | Medium |
| de.smartics.properties.spi.config.ds.DefaultDataSourceManager.print(PrintStream) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 473 | Medium |
| de.smartics.properties.spi.config.ds.DefaultDataSourceManager.dropConfigTable() passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 440 | Low |
| de.smartics.properties.spi.config.ds.DefaultDataSourceManager.execute(Connection, String) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 419 | Low |
| de.smartics.properties.spi.config.ds.DefaultDataSourceManager.initializedTableExists(Connection) passes a nonconstant String to an execute method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 361 | Low |
| A prepared statement is generated from a nonconstant String in de.smartics.properties.spi.config.ds.DefaultDataSourceManager.initProperties(Connection) | SECURITY | SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING | 399 | Low |
de.smartics.properties.spi.config.ds.PropertiesStore
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| de.smartics.properties.spi.config.ds.PropertiesStore.getProperty(String) may fail to clean up java.sql.ResultSet | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 127 | Medium |
| A prepared statement is generated from a nonconstant String in de.smartics.properties.spi.config.ds.PropertiesStore.createGetPropertiesStatement(Connection) | SECURITY | SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING | 281 | Medium |
| A prepared statement is generated from a nonconstant String in de.smartics.properties.spi.config.ds.PropertiesStore.createDeletePropertyStatement(Connection) | SECURITY | SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING | 298 | Low |
| A prepared statement is generated from a nonconstant String in de.smartics.properties.spi.config.ds.PropertiesStore.createGetPropertyStatement(Connection) | SECURITY | SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING | 272 | Low |
| A prepared statement is generated from a nonconstant String in de.smartics.properties.spi.config.ds.PropertiesStore.createSetPropertyStatement(Connection) | SECURITY | SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING | 290 | Low |
de.smartics.properties.spi.config.support.AbstractInMemoryConfigurationProperties
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| de.smartics.properties.spi.config.support.AbstractInMemoryConfigurationProperties.loadDefault(Class) may fail to clean up java.io.InputStream | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 188 | Medium |
de.smartics.properties.spi.config.support.MappedPropertyCollection$1
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class de.smartics.properties.spi.config.support.MappedPropertyCollection$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 134-161 | Low |
de.smartics.properties.spi.config.support.MultiSourceProperties
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| de.smartics.properties.spi.config.support.MultiSourceProperties.add(PropertyLocation, Properties) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 138 | Medium |
de.smartics.properties.spi.config.support.NativePropertyCollection$1
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class de.smartics.properties.spi.config.support.NativePropertyCollection$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 130-146 | Low |
de.smartics.properties.spi.config.support.PropertiesPropertyCollection$1
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class de.smartics.properties.spi.config.support.PropertiesPropertyCollection$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 104-131 | Low |
de.smartics.properties.spi.config.support.PropertyLocationHelper
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in de.smartics.properties.spi.config.support.PropertyLocationHelper.determineAppId(String, String) | STYLE | REC_CATCH_EXCEPTION | 71 | Low |