PMD Results
The following document contains the results of PMD 5.0.2.
Files
de/smartics/properties/api/config/app/ConfigurationPropertiesFactoryFactory.java
| Violation |
Line |
| In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. |
106 |
de/smartics/properties/api/config/domain/ConfigurationProperties.java
| Violation |
Line |
| This class has too many methods, consider refactoring it. |
51 - 562 |
de/smartics/properties/api/config/domain/key/ApplicationIdLoader.java
| Violation |
Line |
| This class has too many methods, consider refactoring it. |
42 - 391 |
de/smartics/properties/impl/config/jndi/JndiConfigurationPropertiesFactory.java
| Violation |
Line |
| New exception is thrown in catch block, original stack trace may be lost |
112 |
de/smartics/properties/impl/config/jndi/JndiPropertyStoreMessageBean.java
| Violation |
Line |
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. |
25 - 107 |
de/smartics/properties/spi/config/cache/CacheConfigurationLoader.java
| Violation |
Line |
| Avoid using exceptions as flow control. |
99 |
| New exception is thrown in catch block, original stack trace may be lost |
111 - 112 |
de/smartics/properties/spi/config/cache/CacheEntryConfiguration.java
| Violation |
Line |
| StringBuffer constructor is initialized with size 16, but has at least 65 characters appended. |
169 |
de/smartics/properties/spi/config/cache/CompoundKey.java
| Violation |
Line |
| Private field 'name' could be made final; it is only initialized in the declaration or constructor. |
45 |
| Private field 'key' could be made final; it is only initialized in the declaration or constructor. |
50 |
| Private field 'stringRepresentation' could be made final; it is only initialized in the declaration or constructor. |
55 |
de/smartics/properties/spi/config/config/PropertiesConfiguration.java
| Violation |
Line |
| The String literal " // " appears 4 times in this file; the first occurrence is on line 181 |
181 |
de/smartics/properties/spi/config/domain/ConfigurationPropertiesProxy.java
| Violation |
Line |
| This class has too many methods, consider refactoring it. |
46 - 396 |
de/smartics/properties/spi/config/domain/key/PathMatcher.java
| Violation |
Line |
| Avoid appending characters as strings in StringBuffer.append. |
162 |
de/smartics/properties/spi/config/ds/JndiDataSourceProxy.java
| Violation |
Line |
| StringBuffer constructor is initialized with size 16, but has at least 25 characters appended. |
155 |
de/smartics/properties/spi/config/support/AbstractConfigurationProperties.java
| Violation |
Line |
| StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. |
594 |
de/smartics/properties/spi/config/support/ClassPathLoader.java
| Violation |
Line |
| StringBuffer constructor is initialized with size 16, but has at least 153 characters appended. |
562 |
de/smartics/properties/spi/config/support/ConfigurationPropertiesManagementWithDefaults.java
| Violation |
Line |
| This class has too many methods, consider refactoring it. |
68 - 558 |
| StringBuffer constructor is initialized with size 16, but has at least 26 characters appended. |
549 |
de/smartics/properties/spi/config/support/FactoryCache.java
| Violation |
Line |
| StringBuffer constructor is initialized with size 16, but has at least 78 characters appended. |
194 |
de/smartics/properties/spi/config/support/InMemoryConfigurationRepositoryManagement.java
| Violation |
Line |
| The String literal "unchecked" appears 5 times in this file; the first occurrence is on line 253 |
253 |
| The String literal "rawtypes" appears 4 times in this file; the first occurrence is on line 253 |
253 |
| StringBuffer constructor is initialized with size 16, but has at least 36 characters appended. |
419 |
de/smartics/properties/spi/config/support/UrlUtil.java
| Violation |
Line |
| All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. |
32 - 137 |
| Prefer StringBuffer over += for concatenating strings |
133 |
de/smartics/properties/spi/config/transfer/DefinitionXmlMessageBean.java
| Violation |
Line |
| Avoid unused private fields such as 'definitionXml'. |
58 |
de/smartics/properties/spi/config/transfer/NoConfigurationKeyForPropertiesMessageBean.java
| Violation |
Line |
| Avoid unused private fields such as 'definitionXml'. |
59 |
de/smartics/properties/spi/config/transfer/PropertyProviderList.java
| Violation |
Line |
| New exception is thrown in catch block, original stack trace may be lost |
208 |
| New exception is thrown in catch block, original stack trace may be lost |
215 |
